Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/home comment #66

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Feat/home comment #66

merged 6 commits into from
Dec 4, 2023

Conversation

chaeyoung103
Copy link
Collaborator

@chaeyoung103 chaeyoung103 commented Dec 3, 2023 •
edited
Loading

홈화면 댓글 컴포넌트 구현 및 디자인 수정사항에 따른 ui 변경
isVote에 따라 댓글 ui 변경되도록 구현
스크린샷 2023-12-03 오후 6 28 03
스크린샷 2023-12-03 오후 6 27 54

close #54

@chaeyoung103 chaeyoung103 self-assigned this Dec 3, 2023
@Jinho1011 Jinho1011 added the feature Implement new feature label Dec 3, 2023
@Jinho1011 Jinho1011 added this to the Sprint 5 milestone Dec 3, 2023
@Jinho1011
Copy link
Member

구현 너무 잘하셨습니다!

다만, TopicCard 컴포넌트 코드가 커지고 있어서 Comment 부분을 컴포넌트로 분리하면 어떨까 싶습니다.

  1. 이후에 comment와 관련된 API를 연동할 때 리렌더링 이슈가 발생할 수 있음
  2. 다른 페이지에서 재사용이 필요할 수도 있음

Jinho1011
Jinho1011 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@Jinho1011 Jinho1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jinho1011 Jinho1011 merged commit 347d88e into dev Dec 4, 2023
1 check passed
@Jinho1011 Jinho1011 deleted the feat/homeComment branch December 5, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jinho1011 Jinho1011 Jinho1011 approved these changes

Assignees

@chaeyoung103 chaeyoung103

Labels
feature Implement new feature
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging this pull request may close these issues.

홈 화면 댓글 컴포넌트 구현
2 participants
@chaeyoung103 @Jinho1011